Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] net: wireless: b43: Avoid possible double calls to b43_one_core_detach() | Date | Mon, 06 May 2019 11:21:55 +0300 |
| |
Jia-Ju Bai <baijiaju1990@gmail.com> writes:
> In b43_request_firmware(), when ieee80211_register_hw() fails, > b43_one_core_detach() is called. In b43_bcma_remove() and > b43_ssb_remove(), b43_one_core_detach() is called again. In this case, > null-pointer dereferences and double-free problems can occur when > the driver is removed. > > To fix this bug, the call to b43_one_core_detach() in > b43_request_firmware() is deleted. > > This bug is found by a runtime fuzzing tool named FIZZER written by us. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/net/wireless/broadcom/b43/main.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-)
You can use just "b43:" as prefix, no need to have "net:" nor "wireless:" in the title. I'll fix it this time, but please use correct style in the future.
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
-- Kalle Valo
| |