lkml.org 
[lkml]   [2019]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/18] perf/x86/intel/rapl: Support multi-die/package

* Len Brown <lenb@kernel.org> wrote:

> On Mon, May 6, 2019 at 7:48 AM Ingo Molnar <mingo@kernel.org> wrote:
>
> > > - unsigned int pkgid = topology_logical_package_id(cpu);
> > > + unsigned int pkgid = topology_logical_die_id(cpu);
>
> > There's many such instances left in this series, please review the whole
> > patchset for such problems.
>
> I agree, the legacy names make the code read as if it were a bug, even
> when it is correct.
> I'll refresh the series with some re-names to make the end result ready clearly.

Thanks a lot!

Ingo

\
 
 \ /
  Last update: 2019-05-06 21:51    [W:0.092 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site