lkml.org 
[lkml]   [2019]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems
    From
    Date
    On 05.05.2019 22:51, Ruslan Babayev wrote:
    > Lookup I2C adapter using the "i2c-bus" device property on ACPI based
    > systems similar to how it's done with DT.
    >
    > An example DSD describing an SFP on an ACPI based system:
    >
    > Device (SFP0)
    > {
    > Name (_HID, "PRP0001")
    > Name (_DSD, Package ()
    > {
    > ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
    > Package () {
    > Package () { "compatible", "sff,sfp" },
    > Package () { "i2c-bus", \_SB.PCI0.RP01.I2C.MUX.CH0 },
    > },
    > })
    > }
    >
    > Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
    > Cc: xe-linux-external@cisco.com
    > ---
    > drivers/net/phy/sfp.c | 33 +++++++++++++++++++++++++--------
    > 1 file changed, 25 insertions(+), 8 deletions(-)
    >
    If we have a patch series touching more than one sub-system a typical
    approach is:
    - Send series to all persons / lists being responsible for the affected
    subsystems
    - Maintainers will agree through which tree the series will go
    - Maintainers of the other subsystems will ACK their respective patches
    of the series

    I just received patch 2/2. The complete series (cover letter + two patches)
    should have gone to i2c and phylib maintainers + lists.

    As an additional hint regarding the commit message:
    I suppose you added this code to support a specific device. Wouldn't hurt
    if you mention which device it is.

    \
     
     \ /
      Last update: 2019-05-05 23:04    [W:3.163 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site