Messages in this thread | | | Subject | Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC | From | <> | Date | Thu, 30 May 2019 15:52:00 +0300 |
| |
On 5/30/19 2:57 PM, Greg KH wrote: > On Thu, May 30, 2019 at 01:15:29PM +0300, Hanna Hawa wrote: >> +static void al_a57_edac_cpumerrsr(void *arg) >> +{ >> + struct edac_device_ctl_info *edac_dev = >> + (struct edac_device_ctl_info *)arg; > No need for casting anything here, just assign it. Doesn't checkpatch > catch this type of thing these days? You did run it, right?
I did, but checkpatch didn't catch this. I'll fix in next patch-set.
Thanks for your review.
Hanna
> > Please fix that up everywhere you do this in the driver. > > > thanks, > > greg k-h
| |