Messages in this thread | | | Date | Wed, 29 May 2019 14:56:34 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.1 077/375] USB: serial: fix initial-termios handling |
| |
On Thu, May 23, 2019 at 07:26:00AM +0200, Johan Hovold wrote: >Hi Sasha, > >On Wed, May 22, 2019 at 03:16:17PM -0400, Sasha Levin wrote: >> From: Johan Hovold <johan@kernel.org> >> >> [ Upstream commit 579bebe5dd522580019e7b10b07daaf500f9fb1e ] >> >> The USB-serial driver init_termios callback is used to override the >> default initial terminal settings provided by USB-serial core. >> >> After a bug was fixed in the original implementation introduced by >> commit fe1ae7fdd2ee ("tty: USB serial termios bits"), the init_termios >> callback was no longer called just once on first use as intended but >> rather on every (first) open. >> >> This specifically meant that the terminal settings saved on (final) >> close were ignored when reopening a port for drivers overriding the >> initial settings. >> >> Also update the outdated function header referring to the creation of >> termios objects. >> >> Fixes: 7e29bb4b779f ("usb-serial: fix termios initialization logic") >> Signed-off-by: Johan Hovold <johan@kernel.org> >> Signed-off-by: Sasha Levin <sashal@kernel.org> > >The stable tag was left out on purpose as this is essentially a new >feature, and definitely a behavioural change which should not be >backported. > >Please drop from your autosel queues.
Dropped!
>Also, may I ask you again not to include usb-serial (and drivers/gnss) >in your autosel processing.
Of course, I've added it to my list.
-- Thanks, Sasha
| |