Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 29 May 2019 16:21:59 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH V2 01/12] irqchip: tegra: do not disable COP IRQ during suspend |
| |
On Tue, May 28, 2019 at 04:08:45PM -0700, Sowjanya Komatineni wrote: > Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry > sequence and sc7 entry firmware is run from COP/BPMP-Lite. > > So, COP/BPMP-Lite still need IRQ function to finish SC7 suspend sequence > for Tegra210. > > This patch has fix for leaving the COP IRQ enabled for Tegra210 during > interrupt controller suspend operation. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > drivers/irqchip/irq-tegra.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c > index 0abc0cd1c32e..deab3ba606e2 100644 > --- a/drivers/irqchip/irq-tegra.c > +++ b/drivers/irqchip/irq-tegra.c > @@ -53,18 +53,22 @@ static unsigned int num_ictlrs; > > struct tegra_ictlr_soc { > unsigned int num_ictlrs; > + bool has_bpmp_fw;
This seems slightly inaccurate to me. My understanding is that we need the AVP/COP to enter/exit SC7 irrespective of whether it runs the BPMP lite firmware. Perhaps something like "supports_sc7" would be a little more accurate?
Other than that:
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |