lkml.org 
[lkml]   [2019]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 255/276] scsi: ufs: fix a missing check of devm_reset_control_get
    Date
    [ Upstream commit 63a06181d7ce169d09843645c50fea1901bc9f0a ]

    devm_reset_control_get could fail, so the fix checks its return value and
    passes the error code upstream in case it fails.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Acked-by: Avri Altman <avri.altman@wdc.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufs-hisi.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
    index 452e19f8fb470..c2cee73a8560d 100644
    --- a/drivers/scsi/ufs/ufs-hisi.c
    +++ b/drivers/scsi/ufs/ufs-hisi.c
    @@ -544,6 +544,10 @@ static int ufs_hisi_init_common(struct ufs_hba *hba)
    ufshcd_set_variant(hba, host);

    host->rst = devm_reset_control_get(dev, "rst");
    + if (IS_ERR(host->rst)) {
    + dev_err(dev, "%s: failed to get reset control\n", __func__);
    + return PTR_ERR(host->rst);
    + }

    ufs_hisi_set_pm_lvl(hba);

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-30 05:26    [W:4.280 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site