Messages in this thread | | | From | Arend Van Spriel <> | Date | Tue, 28 May 2019 18:11:00 +0200 | Subject | Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 |
| |
On May 28, 2019 6:09:21 PM Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> On May 28, 2019 5:52:10 PM Doug Anderson <dianders@chromium.org> wrote: > >> Hi, >> >> On Tue, May 28, 2019 at 5:18 AM Kalle Valo <kvalo@codeaurora.org> wrote: >>> >>> Douglas Anderson <dianders@chromium.org> wrote: >>> >>> > In commit 29f6589140a1 ("brcmfmac: disable command decode in >>> > sdio_aos") we disabled something called "command decode in sdio_aos" >>> > for a whole bunch of Broadcom SDIO WiFi parts. >>> > >>> > After that patch landed I find that my kernel log on >>> > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: >>> > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 >>> > >>> > This seems to happen every time the Broadcom WiFi transitions out of >>> > sleep mode. Reverting the part of the commit that affects the WiFi on >>> > my boards fixes the problem for me, so that's what this patch does. >>> > >>> > Note that, in general, the justification in the original commit seemed >>> > a little weak. It looked like someone was testing on a SD card >>> > controller that would sometimes die if there were CRC errors on the >>> > bus. This used to happen back in early days of dw_mmc (the controller >>> > on my boards), but we fixed it. Disabling a feature on all boards >>> > just because one SD card controller is broken seems bad. ...so >>> > instead of just this patch possibly the right thing to do is to fully >>> > revert the original commit. >>> > >>> > Fixes: 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") >>> > Signed-off-by: Douglas Anderson <dianders@chromium.org> >>> >>> I don't see patch 2 in patchwork and I assume discussion continues. >> >> Apologies. I made sure to CC you individually on all the patches but >> didn't think about the fact that you use patchwork to manage and so >> didn't ensure all patches made it to all lists (by default each patch >> gets recipients individually from get_maintainer). I'll make sure to >> fix for patch set #2. If you want to see all the patches, you can at >> least find them on lore.kernel.org linked from the cover: >> >> https://lore.kernel.org/patchwork/cover/1075373/ >> >> >>> Please resend if/when I need to apply something. >>> >>> 2 patches set to Changes Requested. >>> >>> 10948785 [1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 >> >> As per Arend I'll change patch #1 to a full revert instead of a >> partial revert. Arend: please yell if you want otherwise. > > No yelling here. If any it is expected from Cypress. Maybe good to add them > specifically in Cc:
Of the revert patch that is.
Gr. AvS
| |