lkml.org 
[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] lockd: Make two symbols static
From
Date


> On May 28, 2019, at 11:13 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
>
> On Tue, May 28, 2019 at 06:49:13AM -0400, Benjamin Coddington wrote:
>> Maintainers, what's the best thing to do here: fold these into
>> another patch version and post it (add attribution)? Add it as
>> another patch at the end of the series?
>
> Either would be fine. Yeah, if it was folded in then we'd add a line
> like
>
> [hulkci@huawei.com: make symbols static to fix sparse warnings]
>
> But I'll probably just add it on to the end for now. No need for you to
> do anything.
>
>> I have learned my lesson: add sparse to my workflow.
>
> I dunno, I wonder if we're better off just leaving it to this CI bot.
> It seems like a more efficient use of time overall than making every
> contributor run it.

Occasionally sparse can catch a real problem that breaks bisectability.
Better to do this kind of checking early, and ensure that you test those
sparse-fixed bits.


--
Chuck Lever



\
 
 \ /
  Last update: 2019-05-28 17:21    [W:0.057 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site