Messages in this thread | | | From | Sven Van Asbroeck <> | Date | Tue, 28 May 2019 09:41:40 -0400 | Subject | Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO |
| |
Hello YueHaibing,
On Tue, May 28, 2019 at 9:33 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > > drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe': > arcx-anybus.c:(.text+0x9d6): undefined reference to `__devm_regmap_init_mmio_clk' > > Select REGMAP_MMIO to fix it.
Thank you for noticing this, I appreciate it !
However, when I run this patch through the scripts/checkpatch.pl script, it reports some issues. Could you fix and post v2 please?
checkpatch.pl output follows:
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #68: arcx-anybus.c:(.text+0x9d6): undefined reference to `__devm_regmap_init_mmio_clk'
ERROR: DOS line endings #87: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17: +^Iselect REGMAP_MMIO^M$
total: 1 errors, 1 warnings, 0 checks, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
| |