Messages in this thread | | | Date | Tue, 28 May 2019 14:53:30 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 4/9] perf/x86/intel: Support hardware TopDown metrics |
| |
On Tue, May 21, 2019 at 02:40:50PM -0700, kan.liang@linux.intel.com wrote: > + x86_pmu.has_metric = x86_pmu.intel_cap.perf_metrics;
It makes sense to duplicate that state because?
> @@ -717,6 +729,8 @@ struct x86_pmu { > struct extra_reg *extra_regs; > unsigned int flags; > > + bool has_metric; > + > /* > * Intel host/guest support (KVM) > */
You forgot how I feel about _Bool in composite types _again_ ?
| |