Messages in this thread | | | Date | Tue, 28 May 2019 17:51:40 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [RFC] printk/sysrq: Don't play with console_loglevel |
| |
On (05/28/19 17:02), Tetsuo Handa wrote: > On 2019/05/28 13:22, Sergey Senozhatsky wrote: > > On (05/28/19 12:21), Tetsuo Handa wrote: > > [..] > Dmitry's patch is changing only the header line (in other words, per printk() call). > Since op_p->handler(key) is out of KERN_UNSUPPRESSED effect, the body lines might > not be printed.
Right.
> I think that we need a way to pass KERN_UNSUPPRESSED from printk() > calls invoked from op_p->handler(key).
Right. That's what the per-CPU context bit address.
> You are trying to omit passing KERN_UNSUPPRESSED by utilizing implicit printk > context information. But doesn't such attempt resemble find_printk_buffer() ?
Adding KERN_UNSUPPRESSED to all printks down the op_p->handler() line is hardly possible. At the same time I'd really prefer not to have buffering for sysrq.
-ss
| |