Messages in this thread | | | Date | Tue, 28 May 2019 20:19:06 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] cpumask: Remove error message and backtrace on out-of-memory condition |
| |
On Mon, 27 May 2019 14:29:58 +0200 Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> There is no need to print an error message and backtrace if > kmalloc_node() fails, as the memory allocation core already takes care > of that. > > ... > > --- a/lib/cpumask.c > +++ b/lib/cpumask.c > @@ -114,13 +114,6 @@ bool alloc_cpumask_var_node(cpumask_var_t *mask, gfp_t flags, int node) > { > *mask = kmalloc_node(cpumask_size(), flags, node); > > -#ifdef CONFIG_DEBUG_PER_CPU_MAPS > - if (!*mask) { > - printk(KERN_ERR "=> alloc_cpumask_var: failed!\n"); > - dump_stack(); > - } > -#endif > - > return *mask != NULL; > } > EXPORT_SYMBOL(alloc_cpumask_var_node);
Well, not really - as it stands CONFIG_DEBUG_PER_CPU_MAPS=y can override a caller's __GFP_NOWARN.
I wonder if anyone ever sets CONFIG_DEBUG_PER_CPU_MAPS any more...
| |