lkml.org 
[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524
    On Mon, May 20, 2019 at 10:33 PM Fabio Estevam <festevam@gmail.com> wrote:
    >
    > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote:
    > >
    > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote:
    > >
    > > > + simple-audio-card,codec {
    > > > + sound-dai = <&wm8524>;
    > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
    > >
    > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3
    > > interface, not an external clock that feeds the codec.
    > >
    > > It seems you should remove this 'clocks' entry.
    >
    > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so
    > the representation is correct:
    >
    > Reviewed-by: Fabio Estevam <festevam@gmail.com>

    Shawn,

    Can you have a look?

    \
     
     \ /
      Last update: 2019-05-28 09:11    [W:2.120 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site