lkml.org 
[lkml]   [2019]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 4/6] mm: add a gup_fixup_start_addr hook
    [ Adding Khalid, who added the sparc64 code ]

    On Sat, May 25, 2019 at 6:32 AM Christoph Hellwig <hch@lst.de> wrote:
    >
    > This will allow sparc64 to override its ADI tags for
    > get_user_pages and get_user_pages_fast. I have no idea why this
    > is not required for plain old get_user_pages, but it keeps the
    > existing sparc64 behavior.

    This is actually generic. ARM64 has tagged pointers too. Right now the
    system call interfaces are all supposed to mask off the tags, but
    there's been noise about having the kernel understand them.

    That said:

    > +#ifndef gup_fixup_start_addr
    > +#define gup_fixup_start_addr(start) (start)
    > +#endif

    I'd rather name this much more specifically (ie make it very much
    about "clean up pointer tags") and I'm also not clear on why sparc64
    actually wants this. I thought the sparc64 rules were the same as the
    (current) arm64 rules: any addresses passed to the kernel have to be
    the non-tagged ones.

    As you say, nothing *else* in the kernel does that address cleanup,
    why should get_user_pages_fast() do it?

    David? Khalid? Why does sparc64 actually need this? It looks like the
    generic get_user_pages() doesn't do it.

    Linus

    \
     
     \ /
      Last update: 2019-05-25 19:07    [W:3.733 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site