lkml.org 
[lkml]   [2019]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: ks7010: Remove initialisation
From
Date
On 24/05/19 12:22 PM, Greg KH wrote:
> On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
>> As the initial value of the return variable result is never used, it can
>> be removed.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>> drivers/staging/ks7010/ks7010_sdio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Didn't you already send this?

I sent two patches about removing initialisation in ks7010 today, but I
couldn't make it a patch series because the different files had
different maintainers. I don't think I've sent this patch before, but
it's possible I made a mistake because my local tree has not been the
best organised lately. I apologise for the confusion.

> And please run a spell-checker on your subject line when you resend
> this :)

Is this about "initialise" (and now also "organised", "apologise", etc)?
As far as I'm aware whether the word ends in "-ise"/"-ize" depends on
local varieties of English, so I went with the variety I'm more used to.
Should I stick with American/Canadian spelling variants (including "-or"
over "-our" etc) from now on?

Nishka
>
> thanks,
>
> greg k-h
>

\
 
 \ /
  Last update: 2019-05-24 09:02    [W:0.073 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site