lkml.org 
[lkml]   [2019]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/9] genirq/timings: Use the min kernel macro
On Fri, May 24, 2019 at 01:16:10PM +0200, Daniel Lezcano wrote:
> The' min' is available as a kernel macro. Use it instead of writing
> the same code.

While it's technically correct...

> /*
> * 'count' will depends if the circular buffer wrapped or not
> */
> - count = irqs->count < IRQ_TIMINGS_SIZE ?
> - irqs->count : IRQ_TIMINGS_SIZE;
> + count = min_t(int, irqs->count, IRQ_TIMINGS_SIZE);
>
> start = irqs->count < IRQ_TIMINGS_SIZE ?
> 0 : (irqs->count & IRQ_TIMINGS_MASK);

...looking to the context I would leave as is to have a pattern.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-05-24 15:58    [W:0.102 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site