Messages in this thread | | | Date | Thu, 23 May 2019 21:19:26 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit |
| |
Hi!
> - LEDs > - gyro > - magnetometer
> + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_leds>; > + > + led1 { > + label = "LED 1";
So, what kind of LED do you have, and what color is it? label should probably be something like notify:green.
> + charger@6b { /* bq25896 */ > + compatible = "ti,bq25890"; > + reg = <0x6b>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_charger>; > + interrupt-parent = <&gpio3>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + ti,battery-regulation-voltage = <4192000>; /* 4.192V */ > + ti,charge-current = <1600000>; /* 1.6 A */
No space before A, for consistency.
> + ti,termination-current = <66000>; /* 66mA */ > + ti,precharge-current = <1300000>; /* 1.3A */
I thought precharge is usually something low, because you are not yet sure of battery health...?
> + ti,minimum-sys-voltage = <2750000>; /* 2.75V */
Are you sure? Normally systems shut down at 3.2V, 3V or so. Li-ion batteries don't really like to be discharged _this_ deep.
Pavel
| |