Messages in this thread | | | Subject | Re: [PATCH 1/5] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a | From | Andrzej Hajda <> | Date | Wed, 22 May 2019 08:07:48 +0200 |
| |
On 20.05.2019 15:37, Neil Armstrong wrote: > Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support > for these modes in the connector if the platform supports them. > We limit these modes to DW-HDMI IP version >= 0x200a which > are designed to support HDMI2.0 display modes. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Tested-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ++++++ > include/drm/bridge/dw_hdmi.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index ab7968c8f6a2..b50c49caf7ae 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2629,6 +2629,12 @@ __dw_hdmi_probe(struct platform_device *pdev, > if (hdmi->phy.ops->setup_hpd) > hdmi->phy.ops->setup_hpd(hdmi, hdmi->phy.data); > > + if (hdmi->version >= 0x200a) > + hdmi->connector.ycbcr_420_allowed = > + hdmi->plat_data->ycbcr_420_allowed; > + else > + hdmi->connector.ycbcr_420_allowed = false; > +
I suspect else clause can be dropped.
Beside this:
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
-- Regards Andrzej
> memset(&pdevinfo, 0, sizeof(pdevinfo)); > pdevinfo.parent = dev; > pdevinfo.id = PLATFORM_DEVID_AUTO; > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index 66e70770cce5..0f0e82638fbe 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -130,6 +130,7 @@ struct dw_hdmi_plat_data { > const struct drm_display_mode *mode); > unsigned long input_bus_format; > unsigned long input_bus_encoding; > + bool ycbcr_420_allowed; > > /* Vendor PHY support */ > const struct dw_hdmi_phy_ops *phy_ops;
| |