Messages in this thread | | | From | Laurentiu Tudor <> | Subject | Re: [PATCH v5 2/5] USB: use genalloc for USB HCs with local memory | Date | Wed, 22 May 2019 10:54:02 +0000 |
| |
On 21.05.2019 18:27, Fredrik Noring wrote: > Thanks Laurentiu! > >> --- a/include/linux/usb/hcd.h >> +++ b/include/linux/usb/hcd.h >> @@ -216,6 +216,9 @@ struct usb_hcd { >> #define HC_IS_RUNNING(state) ((state) & __ACTIVE) >> #define HC_IS_SUSPENDED(state) ((state) & __SUSPEND) >> >> + /* allocator for HCs having local memory */ >> + struct gen_pool *localmem_pool; >> + > > I have tested patches 1, 2 and 5, and they seem to work. Nice!
Great! Thanks for testing. I'll add your Tested-By tags on the patches you mentioned.
> May I suggest clarifying the NULL pointers? I think that may help someone > debugging or maintaining this in the future. Something like this:
Sure, will include in v6.
--- Best Regards, Laurentiu
| |