lkml.org 
[lkml]   [2019]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mtd: onenand_base: Avoid fall-through warnings
From
Date


On 5/22/19 5:20 PM, Kees Cook wrote:
> On Wed, May 22, 2019 at 11:57:38PM +0200, Boris Brezillon wrote:
>> All this look suspicious, and even if the fall through logic
>> has no side effects in practice (which I'm still not sure is the case),
>> I think it'd be better to explicitly set the flags that have
>> to be set in each case statement and add breaks.
>
> Yeah, totally agreed. :)
>

Thank you, Kees and Boris for the feedback. Some external opinions were
certainly much needed here.

I'll just wait for any comments from the MTD guys.

Thanks
--
Gustavo

\
 
 \ /
  Last update: 2019-05-23 00:30    [W:1.282 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site