Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 22 May 2019 23:48:45 +0200 | Subject | Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined |
| |
On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY <amelie.delaunay@st.com> wrote:
> ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error: > ‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function) > .dt_node_to_map = pinconf_generic_dt_node_to_map_pin, > > OF_GPIO depends on OF. > > So either > depends on OF || (OF && COMPILE_TEST) > or > depends on OF || (OF_GPIO && COMPILE_TEST) > > and > > select OF_GPIO
I would use just:
depends on OF_GPIO
Because OF_GPIO already depends on OF, and compile tests will not work without OF_GPIO which require OF so...
Besides it is what most other GPIO drivers do.
So just keep that one line and drop the rest.
Yours, Linus Walleij
| |