Messages in this thread | | | From | Sagar Kadam <> | Date | Wed, 22 May 2019 10:28:58 +0530 | Subject | Re: [PATCH v6 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC. |
| |
Hi Andrew,
On Tue, May 21, 2019 at 7:24 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > static void ocores_process_polling(struct ocores_i2c *i2c) > > { > > + const struct of_device_id *match; > > + > > + match = of_match_node(ocores_i2c_match, i2c->adap.dev.of_node); > > + > > while (1) { > > irqreturn_t ret; > > int err; > > Please keep with the idea of i2c->flags, which is set during probe. > Just because it was removed because it was no longer needed does not > stop you from putting it back again if it is needed. > I had modified the implementation, so as to keep it compatible with the new implementation of polling mode. As per your suggestion, I will keep the older method (the v5 version which you Reviewed earlier : https://lkml.org/lkml/2019/5/20/1261) and submit a v7 for this.
> Andrew
Thanks & Regards, Sagar
| |