lkml.org 
[lkml]   [2019]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2
From
Date
On 21/05/2019 18:11, Robin Murphy wrote:
> On 21/05/2019 16:19, Neil Armstrong wrote:
> [...]
>> +        cpu100: cpu@100 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>
> Nit: we've recently tried to eradicate "arm,armv8" as a fallback compatible for real CPUs (although I see there are still a couple of instances that have slipped through).

Thanks for pointing this, I'll remove it.

Neil

>
> Robin.
>
>> +            reg = <0x0 0x100>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +
>> +        cpu101: cpu@101 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>> +            reg = <0x0 0x101>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +
>> +        cpu102: cpu@102 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>> +            reg = <0x0 0x102>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +
>> +        cpu103: cpu@103 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>> +            reg = <0x0 0x103>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +    };
>> +};
>> +
>> +&clkc {
>> +    compatible = "amlogic,g12b-clkc";
>> +};
>>

\
 
 \ /
  Last update: 2019-05-22 10:01    [W:0.095 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site