lkml.org 
[lkml]   [2019]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 056/101] net: xilinx: fix possible object reference leak
    Date
    [ Upstream commit fa3a419d2f674b431d38748cb58fb7da17ee8949 ]

    The call to of_parse_phandle returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1624:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1569, but without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Anirudha Sarangi <anirudh@xilinx.com>
    Cc: John Linn <John.Linn@xilinx.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Michal Simek <michal.simek@xilinx.com>
    Cc: netdev@vger.kernel.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
    index 0789d8af7d72..1ef56edb3918 100644
    --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
    +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
    @@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device *pdev)
    ret = of_address_to_resource(np, 0, &dmares);
    if (ret) {
    dev_err(&pdev->dev, "unable to get DMA resource\n");
    + of_node_put(np);
    goto free_netdev;
    }
    lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares);
    if (IS_ERR(lp->dma_regs)) {
    dev_err(&pdev->dev, "could not map DMA regs\n");
    ret = PTR_ERR(lp->dma_regs);
    + of_node_put(np);
    goto free_netdev;
    }
    lp->rx_irq = irq_of_parse_and_map(np, 1);
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-05-02 17:32    [W:6.227 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site