| Date | Thu, 2 May 2019 12:58:49 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2 07/17] kunit: test: add initial tests |
| |
On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > Add a test for string stream along with a simpler example. > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- > kunit/Kconfig | 12 ++++++ > kunit/Makefile | 4 ++ > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > 4 files changed, 165 insertions(+) > create mode 100644 kunit/example-test.c > create mode 100644 kunit/string-stream-test.c > > diff --git a/kunit/Kconfig b/kunit/Kconfig > index 64480092b2c24..5cb500355c873 100644 > --- a/kunit/Kconfig > +++ b/kunit/Kconfig > @@ -13,4 +13,16 @@ config KUNIT > special hardware. For more information, please see > Documentation/kunit/ > > +config KUNIT_TEST > + bool "KUnit test for KUnit" > + depends on KUNIT > + help > + Enables KUnit test to test KUnit. > + > +config KUNIT_EXAMPLE_TEST > + bool "Example test for KUnit" > + depends on KUNIT > + help > + Enables example KUnit test to demo features of KUnit.
Can't these tests be module?
Or am I mis-reading the previous logic?
Anyway, just a question, nothing objecting to this as-is for now.
thanks,
greg k-h
|