Messages in this thread | | | Date | Thu, 2 May 2019 13:37:46 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH V2 0/3] watchdog: stm32: add dynamic prescaler support |
| |
On Thu, May 02, 2019 at 04:08:43PM +0200, Ludovic Barre wrote: > From: Ludovic Barre <ludovic.barre@st.com> > > This patch series updates stm32 watchdog driver on: > -use devm_watchdog_register_device > -Guenter's recommendation about return value: > set_timeout return 0 on succes, -EINVAL for "parameter out of range" > and -EIO for "could not write value to the watchdog".
No, sorry, that is not what I meant.
set_timeout() should set ->timeout either to the requested value if equal to or larger than the maximum timeout supported by the hardware, and to the actually selected timeout otherwise.
Guenter
> Set of reload and prescaler registers are stay in start function, > because the stm32 watchdog must be enabled to write these registers. > -adds dynamic prescaler support > > Ludovic Barre (3): > watchdog: stm32: update to devm_watchdog_register_device > watchdog: stm32: update return values recommended by watchdog kernel > api > watchdog: stm32: add dynamic prescaler support > > drivers/watchdog/stm32_iwdg.c | 96 ++++++++++++++++++++++++------------------- > 1 file changed, 54 insertions(+), 42 deletions(-) > > -- > 2.7.4 >
| |