Messages in this thread | | | From | Paul Burton <> | Subject | Re: [PATCH 08/15] mips: switch to generic version of pte allocation | Date | Thu, 2 May 2019 19:09:47 +0000 |
| |
Hi Mike,
On Thu, May 02, 2019 at 06:28:35PM +0300, Mike Rapoport wrote: > MIPS allocates kernel PTE pages with > > __get_free_pages(GFP_KERNEL | __GFP_ZERO, PTE_ORDER) > > and user PTE pages with > > alloc_pages(GFP_KERNEL | __GFP_ZERO, PTE_ORDER)
That bit isn't quite true - we don't use __GFP_ZERO in pte_alloc_one() & instead call clear_highpage() on the allocated page. Not that I have a problem with using __GFP_ZERO - it seems like the more optimal choice. It just might be worth mentioning the change & expected equivalent behavior.
Otherwise:
Acked-by: Paul Burton <paul.burton@mips.com>
Thanks, Paul
| |