Messages in this thread | | | Date | Fri, 17 May 2019 12:08:00 -0600 | From | Subash Abhinov Kasiviswanathan <> | Subject | Re: [PATCH 02/18] soc: qcom: create "include/soc/qcom/rmnet.h" |
| |
On 2019-05-17 11:27, Alex Elder wrote: > On 5/15/19 8:09 PM, Subash Abhinov Kasiviswanathan wrote: > . . . >> Hi Alex >> >> Could we instead have the rmnet header definition in >> include/linux/if_rmnet.h > > I have no objection to that, but I don't actually know what > the criteria are for putting a file in that directory. > > Glancing at other "if_*" files there it seems sensible, but > because I don't know, I'd like to have a little better > justification. > > Can you provide a good explanation about why these > definitions belong in "include/linux/if_rmnet.h" instead > of "include/soc/qcom/rmnet.h"? > > Thanks. > > -Alex
rmnet was designed similar to vlan / macvlan / ipvlan / bridge. These drivers support creation of virtual netdevices, define custom rtnl_link_ops, expose netlink attributes to uapi via if_link.h and register rx_handlers.
They expose some common structs and helpers via if_vlan.h / if_macvlan.h / if_bridge.h. I would prefer rmnet to use if_rmnet.h similar to them.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |