Messages in this thread | | | Date | Mon, 13 May 2019 07:50:31 -0600 | From | Keith Busch <> | Subject | Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure |
| |
On Sun, May 12, 2019 at 08:54:15AM -0700, Akinobu Mita wrote: > +static void nvme_coredump_logs(struct nvme_dev *dev) > +{ > + struct dev_coredumpm_bulk_data *bulk_data; > + > + if (!dev->dumps) > + return; > + > + bulk_data = nvme_coredump_alloc(dev, 1); > + if (!bulk_data) > + return; > + > + if (nvme_coredump_telemetry_log(bulk_data, &dev->ctrl)) > + dev->num_dumps--; > +}
You'll need this function to return the same 'int' value from nvme_coredump_telemetry_log. A negative value here means that the device didn't produce a response, and that's important to check from the reset work since you'll need to abort the reset if that happens.
| |