Messages in this thread | | | Date | Fri, 10 May 2019 10:54:00 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations |
| |
On Fri, 10 May 2019 14:17:20 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> But both ftrace and retprobes are at C function call boundaries. > Preserving flags doesn't make sense.
I agree, but I did it just because of my OCD and being complete in "emulating an int3" for ftrace_regs_caller ;-)
Yeah, we can remove the popfl from the ftrace trampoline.
-- Steve
| |