Messages in this thread | | | Date | Fri, 10 May 2019 14:56:54 +0200 | From | osalvador@suse ... | Subject | Re: [PATCH v8 03/12] mm/sparsemem: Add helpers track active portions of a section at boot |
| |
On 2019-05-07 01:39, Dan Williams wrote: > Prepare for hot{plug,remove} of sub-ranges of a section by tracking a > sub-section active bitmask, each bit representing a PMD_SIZE span of > the > architecture's memory hotplug section size. > > The implications of a partially populated section is that pfn_valid() > needs to go beyond a valid_section() check and read the sub-section > active ranges from the bitmask. The expectation is that the bitmask > (subsection_map) fits in the same cacheline as the valid_section() > data, > so the incremental performance overhead to pfn_valid() should be > negligible. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Logan Gunthorpe <logang@deltatee.com> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: Pavel Tatashin <pasha.tatashin@soleen.com> > Tested-by: Jane Chu <jane.chu@oracle.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Now that the handling is done in pfn/nr_pages, it looks better to me:
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Thanks
| |