Messages in this thread | | | Date | Wed, 1 May 2019 10:26:27 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 3/3] backlight: lm3630a: add firmware node support |
| |
Hi!
> > @@ -396,13 +506,20 @@ static int lm3630a_probe(struct i2c_client *client, > > GFP_KERNEL); > > if (pdata == NULL) > > return -ENOMEM; > > + > > /* default values */ > > - pdata->leda_ctrl = LM3630A_LEDA_ENABLE; > > - pdata->ledb_ctrl = LM3630A_LEDB_ENABLE; > > + pdata->leda_ctrl = LM3630A_LEDA_DISABLE; > > + pdata->ledb_ctrl = LM3630A_LEDB_DISABLE; > > This is not needed since default is disabled and kzalloc will set these to 0
Let compiler do this kind of optimalizations. Code makes sense as-is.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |