lkml.org 
[lkml]   [2019]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] backlight: lm3630a: add firmware node support
Hi!

> > @@ -396,13 +506,20 @@ static int lm3630a_probe(struct i2c_client *client,
> > GFP_KERNEL);
> > if (pdata == NULL)
> > return -ENOMEM;
> > +
> > /* default values */
> > - pdata->leda_ctrl = LM3630A_LEDA_ENABLE;
> > - pdata->ledb_ctrl = LM3630A_LEDB_ENABLE;
> > + pdata->leda_ctrl = LM3630A_LEDA_DISABLE;
> > + pdata->ledb_ctrl = LM3630A_LEDB_DISABLE;
>
> This is not needed since default is disabled and kzalloc will set these to 0

Let compiler do this kind of optimalizations. Code makes sense as-is.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-05-01 10:26    [W:0.039 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site