lkml.org 
[lkml]   [2019]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] platform/x86: thinkpad_acpi: Mark expected switch fall-throughs
From
Date


On 4/24/19 7:55 PM, ibm-acpi@hmh.eng.br wrote:
> On Wed, Apr 24, 2019, at 16:05, Kees Cook wrote:
>> On Wed, Apr 24, 2019 at 11:15 AM Gustavo A. R. Silva
>> <gustavo@embeddedor.com> wrote:
>>>
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warnings:
>>>

[..]

>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> Notice that, in this particular case, the code comments are modified
>>> in accordance with what GCC is expecting to find.
>>>
>>> This patch is part of the ongoing efforts to enable
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>

Thank you both, Kees and Henrique.

Friendly ping:

Who can take this?

Thanks
--
Gustavo

\
 
 \ /
  Last update: 2019-05-01 22:44    [W:0.042 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site