Messages in this thread | | | From | Sami Tolvanen <> | Date | Wed, 1 May 2019 10:00:10 -0700 | Subject | Re: fix filler_t callback type mismatches |
| |
On Wed, May 1, 2019 at 9:07 AM Christoph Hellwig <hch@lst.de> wrote: > > Casting mapping->a_ops->readpage to filler_t causes an indirect call > type mismatch with Control-Flow Integrity checking. This change fixes > the mismatch in read_cache_page_gfp and read_mapping_page by adding > using a NULL filler argument as an indication to call ->readpage > directly, and by passing the right parameter callbacks in nfs and jffs2. >
Thanks, Christoph! This looks much cleaner.
I tested the patches on a kernel compiled with clang's -fsanitize=cfi and the fixes look good to me. However, you missed one more type mismatch in v9fs_vfs_readpages (fs/9p/vfs_addr.c). Could you please add that one to the series too?
Sami
| |