Messages in this thread | | | Date | Wed, 1 May 2019 12:01:14 +0100 | From | Mark Rutland <> | Subject | Re: arm64: Fix size of __early_cpu_boot_status |
| |
On Tue, Apr 30, 2019 at 04:05:04PM +0530, Arun KS wrote: > __early_cpu_boot_status is of type long. Use quad > assembler directive to allocate proper size. > > Signed-off-by: Arun KS <arunks@codeaurora.org> > --- > arch/arm64/kernel/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index eecf792..115f332 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -684,7 +684,7 @@ ENTRY(__boot_cpu_mode) > * with MMU turned off. > */ > ENTRY(__early_cpu_boot_status) > - .long 0 > + .quad 0
This is the last element in .mmuoff.data.write, which is padded to 2K, so luckily we don't clobber anything else (and don't need a backport).
For consistency with __boot_cpu_mode, we could instead change the c declaration to int, and fix up the calls to update_early_cpu_boot_status, to use a w register, but either way:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> > .popsection > > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |