Messages in this thread | | | Subject | Re: [PATCH v3 0/4] perf: Support a new 'percore' event qualifier | From | "Jin, Yao" <> | Date | Wed, 10 Apr 2019 10:32:13 +0800 |
| |
Hi Arnaldo,
Can this patch be accepted?
Thanks Jin Yao
On 3/19/2019 6:20 PM, Jiri Olsa wrote: > On Tue, Mar 19, 2019 at 04:56:52PM +0800, Jin Yao wrote: >> The 'percore' event qualifier which sums up the event counts for both >> hardware threads in a core. For example, >> >> perf stat -e cpu/event=0,umask=0x3,percore=1/,cpu/event=0,umask=0x3/ >> >> In this example, we count the event 'ref-cycles' per-core and per-CPU in >> one perf stat command-line. >> >> We can already support per-core counting with --per-core, but it's >> often useful to do this together with other metrics that are collected >> per CPU (per hardware thread). So this patch series supports this >> per-core counting on a event level. >> >> v3: >> --- >> Simplify the patch: "perf: Add a 'percore' event qualifier" >> Other patches don't have changes. > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > thanks, > jirka > >> >> v2: >> --- >> 1. Change 'coresum' to 'percore'. >> 2. Move the aggregate counts printing to a seperate patch. >> >> Jin Yao (4): >> perf: Add a 'percore' event qualifier >> perf stat: Factor out aggregate counts printing >> perf stat: Support 'percore' event qualifier >> perf test: Add a simple test for term 'percore' >> >> tools/perf/Documentation/perf-stat.txt | 4 ++ >> tools/perf/builtin-stat.c | 21 +++++++ >> tools/perf/tests/parse-events.c | 10 ++- >> tools/perf/util/evsel.c | 2 + >> tools/perf/util/evsel.h | 3 + >> tools/perf/util/parse-events.c | 27 +++++++++ >> tools/perf/util/parse-events.h | 1 + >> tools/perf/util/parse-events.l | 1 + >> tools/perf/util/stat-display.c | 108 ++++++++++++++++++++++++--------- >> tools/perf/util/stat.c | 8 ++- >> 10 files changed, 151 insertions(+), 34 deletions(-) >> >> -- >> 2.7.4 >>
| |