Messages in this thread | | | Date | Tue, 9 Apr 2019 16:41:41 +0300 | From | Jarkko Sakkinen <> | Subject | Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED) |
| |
On Mon, Apr 08, 2019 at 07:53:34AM +0200, Martin Kepplinger wrote: > On 21.03.19 14:41, Jarkko Sakkinen wrote: > > On Tue, Mar 19, 2019 at 04:03:37PM -0700, Paul Zimmerman wrote: > >> So I bisected this down to: > >> > >> # first bad commit: [a3fbfae82b4cb3ff9928e29f34c64d0507cad874] tpm: > >> take TPM chip power gating out of tpm_transmit() > >> > >> but this doesn't revert cleanly on Linus' HEAD. Anyone have an idea what > >> could be wrong here? > > > > Sorry I've been in flu for the early week. I spotted the bug > > immediately. When I did these patches I did not have TPM 1.x at my > > hand. I used fTPM 2.0 and dTPM 2.0. Stefan did TPM 1.x testing but I > > probably forgot to ask him to try out suspend. > > > > Anyway, the bug is obvious and I'll send you a patch to try out. > > Thanks a lot for bisecting this! > > > > /Jarkko > > > > > Hi, > > Any news on this? It seems not to be fixed in -rc4. I'd happily test a > patch too. > > thanks a lot, > > martin
I sent a PR to James last week with the fix. Probably has not landed yet.
https://lore.kernel.org/linux-integrity/20190329115544.GA27351@linux.intel.com/
/Jarkko
| |