Messages in this thread | | | Date | Mon, 8 Apr 2019 12:17:09 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH v4 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver |
| |
Hi Mickael,
On Mon, Apr 08, 2019 at 08:20:09AM +0000, Mickael GUENE wrote: ... > > The above are just minor improvements and cleanups. If you're fine with the > > proposed change to the first patch, I can merge this version of the patches > > and you could submit changes to the above in a separate patch. > > > Thanks for the proposal, but I prefer to to a full v5 if you agree ?
That is fine, too.
> I will also add MEDIA_BUS_FMT_BGR888_3X8 or MEDIA_BUS_FMT_BGR888_3X8_BE > support.
Ack. Please add a separate patch for that.
I guess postfix isn't needed as changing the endianness just changes the pixel order in this case.
> >> + .remove = mipid02_remove, > >> +}; > >> + > >> +module_i2c_driver(mipid02_i2c_driver); > >> + > >> +MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>"); > >> +MODULE_DESCRIPTION("STMicroelectronics MIPID02 CSI-2 bridge driver"); > >> +MODULE_LICENSE("GPL v2");
-- Sakari Ailus sakari.ailus@linux.intel.com
| |