Messages in this thread | | | Subject | Re: [RFC PATCH v2 1/3] arch/x86: add the support of ACRN guest | From | "Zhao, Yakui" <> | Date | Mon, 8 Apr 2019 11:36:31 +0800 |
| |
On 2019年04月06日 03:01, Thomas Gleixner wrote: > Zhao, > > On Tue, 26 Mar 2019, Zhao Yakui wrote: > > Vs. the Subject line: arch/x86: add the support of ACRN guest > > The proper prefix for x86 is surprisingly 'x86:' not 'arch/x86:'. Also > please start the first word after the colon with an upper case letter. > >> ACRN is one open-source hypervisour, which is maintained by Linux > > s/one/an/ > >> foundation. > > by the Linuxfoundation. > >> This is to add the para-virtualization support so that >> it allows the Linux guest to run on acrn-hypervisor. >> >> This adds x86_hyper_acrn into supported hypervisors array, which enables >> Linux ACRN guest running on ACRN hypervisor. It is restricted to X86_64. > > Please do not use 'This is to add' or 'This adds'. Just say: > > Add .... > >> v1->v2: Change the CONFIG_ACRN to CONFIG_ACRN_GUEST, which makes it easy to >> understand. >> Remove the export of x86_hyper_acrn. > > Thanks for having the version changes documented, but please put them after > the '---' line below and add another '---' before the diffstat. These > changes are not part of the final change log and if they are below then I > don't have to strip them manually. >
Sure. It will be updated.
>> Co-developed-by: Jason Chen CJ <jason.cj.chen@intel.com> >> Signed-off-by: Jason Chen CJ <jason.cj.chen@intel.com> >> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com> >> --- >> arch/x86/Kconfig | 8 ++++++++ >> arch/x86/include/asm/hypervisor.h | 1 + >> arch/x86/kernel/cpu/Makefile | 1 + >> arch/x86/kernel/cpu/acrn.c | 35 +++++++++++++++++++++++++++++++++++ >> arch/x86/kernel/cpu/hypervisor.c | 4 ++++ >> 5 files changed, 49 insertions(+) >> create mode 100644 arch/x86/kernel/cpu/acrn.c >> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index c1f9b3c..d73225e 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -842,6 +842,14 @@ config JAILHOUSE_GUEST >> cell. You can leave this option disabled if you only want to start >> Jailhouse and run Linux afterwards in the root cell. >> >> +config ACRN_GUEST >> + bool "ACRN Guest support" >> + depends on X86_64 && PARAVIRT > > Why does this select PARAVIRT? The current patches are not implementing > anything of the paravirt functionality. Which part of paravirtualization > are you going to provide?
Thanks for your nice and careful review. Yes. The CONFIG_PARAVIRT is not required. It will be removed.
> > Thanks, > > tglx >
| |