Messages in this thread | | | From | Nick Desaulniers <> | Date | Fri, 5 Apr 2019 10:18:26 -0700 | Subject | Re: [PATCH v3] gcov: fix when CONFIG_MODULES is not set |
| |
On Wed, Apr 3, 2019 at 8:27 AM Matthew Wilcox <willy@infradead.org> wrote: > > On Tue, Apr 02, 2019 at 10:09:56AM +0700, trong@android.com wrote: > > From: Tri Vo <trong@android.com> > > > > Fixes: 8c3d220cb6b5 ("gcov: clang support") > > I think this is the wrong fix. Why not simply:
I spoke with Tri quickly about this proposal and we agree it's a better fix.
Andrew, would you mind dropping: https://ozlabs.org/~akpm/mmotm/broken-out/gcov-clang-support-fix.patch ?
Matthew, would you please send that patch with a commit message? Or if you would prefer us to send with your suggested-by tag, we can do that, too. Whichever you prefer, please let me know. Thanks for the suggestion.
> > +++ b/include/linux/module.h > @@ -709,6 +709,11 @@ static inline bool is_module_text_address(unsigned long addr) > return false; > } > > +static inline bool within_module(unsigned long addr, const struct module *mod) > +{ > + return false; > +} > + > /* Get/put a kernel symbol (calls should be symmetric) */ > #define symbol_get(x) ({ extern typeof(x) x __attribute__((weak)); &(x); }) > #define symbol_put(x) do { } while (0) >
-- Thanks, ~Nick Desaulniers
| |