Messages in this thread | | | Date | Fri, 5 Apr 2019 18:30:15 +0200 | From | Luis Ressel <> | Subject | Re: [PATCH] objtool: Don't use -Werror |
| |
On Fri, Apr 05, 2019 at 11:15:41AM -0500, Josh Poimboeuf wrote: > I consider that a good thing, because I *want* the build to be broken > when somebody uses a bad version of libelf. A patch to produce a more > useful error message (e.g., "bad version of libelf") would be welcome of > course.
Do that if you must, but please do it properly (i.e. check the libelf version and error out explicitly with a suitable message, instead of relying on -Werror), and don't backport the change to stable kernels.
The patch which I referenced in my commit message suddently broke the build for me between 4.19.32 and .33; I consider that a regression which ought to be fixed.
Regards, Luis
| |