Messages in this thread | | | Subject | Re: [PATCH][next] net: hns: fix unsigned comparison to less than zero | From | Mukesh Ojha <> | Date | Fri, 5 Apr 2019 19:40:32 +0530 |
| |
On 4/5/2019 7:29 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently mskid is unsigned and hence comparisons with negative > error return values are always false. Fix this by making mskid an > int. > > Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem") > Addresses-Coverity: ("Operands don't affect result") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers, -Mukesh > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > index 61eea6ac846f..e05d2095d09b 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > @@ -2769,7 +2769,7 @@ static void set_promisc_tcam_enable(struct dsaf_device *dsaf_dev, u32 port) > struct hns_mac_cb *mac_cb; > u8 addr[ETH_ALEN] = {0}; > u8 port_num; > - u16 mskid; > + int mskid; > > /* promisc use vague table match with vlanid = 0 & macaddr = 0 */ > hns_dsaf_set_mac_key(dsaf_dev, &mac_key, 0x00, port, addr);
| |