lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 172/187] drm/nouveau: Stop using drm_crtc_force_disable
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 934c5b32a5e43d8de2ab4f1566f91d7c3bf8cb64 ]

    The correct way for legacy drivers to update properties that need to
    do a full modeset, is to do a full modeset.

    Note that we don't need to call the drm_mode_config_internal helper
    because we're not changing any of the refcounted paramters.

    v2: Fixup error handling (Ville). Since the old code didn't bother
    I decided to just delete it instead of adding even more code for just
    error handling.

    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1)
    Cc: Sean Paul <seanpaul@chromium.org>
    Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20181217194303.14397-2-daniel.vetter@ffwll.ch
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
    index 6a4ca139cf5d..8fd8124d72ba 100644
    --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
    +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
    @@ -750,7 +750,9 @@ static int nv17_tv_set_property(struct drm_encoder *encoder,
    /* Disable the crtc to ensure a full modeset is
    * performed whenever it's turned on again. */
    if (crtc)
    - drm_crtc_force_disable(crtc);
    + drm_crtc_helper_set_mode(crtc, &crtc->mode,
    + crtc->x, crtc->y,
    + crtc->primary->fb);
    }

    return 0;
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-04-04 11:07    [W:2.453 / U:1.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site