Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards | Date | Thu, 04 Apr 2019 08:20:08 +0300 |
| |
Douglas Anderson <dianders@chromium.org> writes:
> The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent > adapter status variables") had a fairly straightforward bug in it. It > contained this bit of diff: > > - if (!adapter->is_suspended) { > + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) { > > As you can see the patch missed the "!" when converting to the atomic > bitops. This meant that the resume hasn't done anything at all since > that commit landed and suspend/resume for mwifiex SDIO cards has been > totally broken. > > After fixing this mwifiex suspend/resume appears to work again, at > least with the simple testing I've done. > > Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables") > Signed-off-by: Douglas Anderson <dianders@chromium.org>
I'm planning to queue this for 5.1.
-- Kalle Valo
| |