Messages in this thread | | | From | Dmitry Torokhov <> | Date | Thu, 4 Apr 2019 10:43:24 -0700 | Subject | Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name |
| |
On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck <groeck@google.com> wrote: > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews <ncrews@chromium.org> wrote: > > > > We want all backlights for the system keyboard to > > use a common name, so the name "platform::kbd_backlight" > > would be better than the current "chromeos::kbd_backlight" > > name. Normally this wouldn't be worth changing, but the new > > Wilco keyboard backlight driver uses the "platform" name. > > We want to make it so all Chrome OS devices are consistent, > > so we'll change the name here too. > > > > Wondering - who is the "we" you are talking about ?
This also has a potential of breaking existing setups if somebody did happen to match on entire name instead of suffix. Such changes have to be considered very carefully; at this point I am against of doing this.
Thanks.
-- Dmitry
| |