lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: musb: Disable pullup in gadget setup
On Thu, Apr 04, 2019 at 11:37:43AM +0200, Paul Cercueil wrote:
> The pullup may be already enabled before the driver is initialized.
> It has to be disabled at init time, as we cannot guarantee that a gadget
> driver will be bound to the UDC.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/usb/musb/musb_gadget.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index ffe462a657b1..094dc59c834c 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -1794,6 +1794,7 @@ int musb_gadget_setup(struct musb *musb)
>
> musb->is_active = 0;
> musb_platform_try_idle(musb, 0);
> + musb_pullup(musb, 0);
>
> status = usb_add_gadget_udc(musb->controller, &musb->g);
> if (status)

Applied.

Thanks,
-Bin.

\
 
 \ /
  Last update: 2019-04-04 18:12    [W:0.070 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site