Messages in this thread | | | Subject | Re: [PATCH 1/2] mm, memory_hotplug: cleanup memory offline path | From | David Hildenbrand <> | Date | Thu, 4 Apr 2019 16:47:43 +0200 |
| |
On 04.04.19 15:25, Oscar Salvador wrote: > On Thu, Apr 04, 2019 at 03:18:00PM +0200, David Hildenbrand wrote: >>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>> index f206b8b66af1..d8a3e9554aec 100644 >>> --- a/mm/memory_hotplug.c >>> +++ b/mm/memory_hotplug.c >>> @@ -1451,15 +1451,11 @@ static int >>> offline_isolated_pages_cb(unsigned long start, unsigned long nr_pages, >>> void *data) >>> { >>> - __offline_isolated_pages(start, start + nr_pages); >>> - return 0; >>> -} >>> + unsigned long offlined_pages; >>> >>> -static void >>> -offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) >>> -{ >>> - walk_system_ram_range(start_pfn, end_pfn - start_pfn, NULL, >>> - offline_isolated_pages_cb); >>> + offlined_pages = __offline_isolated_pages(start, start + nr_pages); >>> + *(unsigned long *)data += offlined_pages; >> >> unsigned long *offlined_pages = data; >> >> *offlined_pages += __offline_isolated_pages(start, start + nr_pages); > > Yeah, more readable. > >> Only nits > > About the identation, I double checked the code and it looks fine to me. > In [1] looks fine too, might be your mail client? > > [1] https://patchwork.kernel.org/patch/10885571/
Double checked, alignment on the parameter on the new line is very weird.
And both lines cross 80 lines per line ... nit :)
> >> >> Reviewed-by: David Hildenbrand <david@redhat.com> > > Thanks ;-) >
--
Thanks,
David / dhildenb
| |