Messages in this thread | | | Date | Thu, 4 Apr 2019 17:02:01 +0300 | From | "Dmitry V. Levin" <> | Subject | Re: [PATCH 4/6 v3] csky: Fix syscall_get_arguments() and syscall_set_arguments() |
| |
On Mon, Apr 01, 2019 at 09:41:08AM -0400, Steven Rostedt wrote: > From: "Dmitry V. Levin" <ldv@altlinux.org> > > C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1] > fields of struct pt_regs. > > Due to an off-by-one bug and a bug in pointer arithmetic > syscall_get_arguments() was reading orig_a0,regs[1..5] fields instead. > Likewise, syscall_set_arguments() was writing orig_a0,regs[1..5] fields > instead. > > Link: http://lkml.kernel.org/r/20190329171230.GB32456@altlinux.org > > Fixes: 4859bfca11c7d ("csky: System Call") > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: Andy Lutomirski <luto@amacapital.net> > Cc: Will Drewry <wad@chromium.org> > Cc: Guo Ren <guoren@kernel.org> > Cc: stable@vger.kernel.org # v4.20+ > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
According to https://lore.kernel.org/lkml/20190330004949.GA15705@guoren-Inspiron-7460/ the following tags could be added to this patch:
Tested-by: Guo Ren <ren_guo@c-sky.com> Acked-by: Guo Ren <ren_guo@c-sky.com>
-- ldv [unhandled content-type:application/pgp-signature] | |