Messages in this thread | | | Subject | Re: [PATCH] mm/gup.c: fix the wrong comments | From | William Kucharski <> | Date | Thu, 4 Apr 2019 06:32:20 -0600 |
| |
> On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@iluvatar.ai> wrote: > > > + * This function is different from the get_user_pages_unlocked(): > + * The @pages may has different page order with the result > + * got by get_user_pages_unlocked(). > + *
I suggest a slight rewrite of the comment, something like:
* Note this routine may fill the pages array with entries in a * different order than get_user_pages_unlocked(), which may cause * issues for callers expecting the routines to be equivalent.
| |